Skip to content

Remove @override setting in IntelliJ #29462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mit-mit opened this issue Apr 25, 2017 · 5 comments
Closed

Remove @override setting in IntelliJ #29462

mit-mit opened this issue Apr 25, 2017 · 5 comments
Labels
area-intellij Tracking issues for the Dart IntelliJ plugin.

Comments

@mit-mit
Copy link
Member

mit-mit commented Apr 25, 2017

We no longer require @OverRide to override fields: #28117

Does that mean we can remove this setting in IntelliJ?
screen shot 2017-04-25 at 12 49 11

@mit-mit mit-mit added the area-intellij Tracking issues for the Dart IntelliJ plugin. label Apr 25, 2017
@alexander-doroshko
Copy link

@mit-mit this option is not related to the analysis server or any other part of the SDK. Quick fixes / quick assists from the SDK are not configurable and AFAIK they do insert @override when possible. This IDE setting is for similar actions that are implemented at IDE side without using the analysis server.

@mit-mit
Copy link
Member Author

mit-mit commented Apr 25, 2017

Sorry, I don't know what that means. Can you give an example of how this is used?

@alexander-doroshko
Copy link

@mit-mit I mean I by chance noticed an issue filed in the Dart SDK issue tracker and decided to mention that this setting in IntelliJ is not related to anything from the Dart SDK git repository, so probably this is not the best place to track/discuss.

@alexander-doroshko
Copy link

Background info:
Quick fix to implement missing members that comes from the Analysis Server is not configurable and as of now it always inserts @override:
image

The Dart plugin also has its own actions to override or to implement members. Implementation is fully at the plugin end, it doesn't use Analysis Server. Shortcuts are Ctrl+I and Ctlr+O, also available via Generate menu (Cmd+N or Ctrl+Enter). These actions do use the setting from your screenshot. Issues related to these IDE-level actions are welcome in https://youtrack.jetbrains.com/issues/WEB
image

@mit-mit
Copy link
Member Author

mit-mit commented Apr 25, 2017

Thanks, I understand. We can close this.

@mit-mit mit-mit closed this as completed Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-intellij Tracking issues for the Dart IntelliJ plugin.
Projects
None yet
Development

No branches or pull requests

2 participants