Skip to content

check outer package dependencies in subpackage_dependencies_test #30271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sigmundch opened this issue Jul 26, 2017 · 2 comments
Open

check outer package dependencies in subpackage_dependencies_test #30271

sigmundch opened this issue Jul 26, 2017 · 2 comments
Labels
legacy-area-front-end Legacy: Use area-dart-model instead. P3 A lower priority bug or feature request

Comments

@sigmundch
Copy link
Member

No description provided.

@sigmundch sigmundch added the legacy-area-front-end Legacy: Use area-dart-model instead. label Jul 26, 2017
@jensjoha
Copy link
Contributor

jensjoha commented Jan 5, 2018

Could you provide more details?

@jensjoha jensjoha added the P3 A lower priority bug or feature request label Jan 5, 2018
@sigmundch
Copy link
Member Author

subpackage_dependencies_test was written to ensure that we didn't pull in unnecessary dependencies in package:front_end. We talked about two kind of dependencies:

  • internal dependencies between folders: we currently test these and we added them because package:front_end includes code that is needed by analyzer, but not by other backends of the front_end
  • external dependencies: we have no checks for these, but the goal was to check that we carefully review whenever we add a new dependency, especially when we import another package from the fasta directory, indicating that this will be a dependency for all users of the front-end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy-area-front-end Legacy: Use area-dart-model instead. P3 A lower priority bug or feature request
Projects
None yet
Development

No branches or pull requests

2 participants