Skip to content

Define "dart.library.mirrors" and "dart.library.isolate" as false in dart2js #30539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
munificent opened this issue Aug 24, 2017 · 5 comments
Closed
Assignees
Milestone

Comments

@munificent
Copy link
Member

Since Dart 2.0 does not support those libraries on the web (#30538), the fromEnvironment() flags for those should return false.

@jmesserly
Copy link

FYI, some dependency cleanup:
https://dart-review.googlesource.com/c/sdk/+/43581 removes dart:io dependency on dart:isolate
https://dart-review.googlesource.com/c/sdk/+/43860 removes dart:html dependency on dart:isolate

that may help if dart2js wants to disable "dart:isolate" import statically.

@dgrove
Copy link
Contributor

dgrove commented Mar 18, 2018

@sigmundch is this done with the new FE?

@dgrove dgrove modified the milestones: 2.0, Dart2 Beta 3 Mar 18, 2018
@sigmundch
Copy link
Member

Not yet - in fact, dart.libraries.io incorrectly returns true now that we are using the CFE

@sigmundch
Copy link
Member

sigmundch commented Mar 21, 2018

Work is in progress here. The main challenge is that we want to allow imports to these libraries and throw runtime errors instead of a static errors for a while longer. To support that we have to:

  • extend CFE to answer consistently on config-specific imports based on the libraries-specification file (libraries.json)
  • integrate dart2js and CFE to pass along a libraries.json file
  • update how dart2js implements dart.library.* const expressions

@sigmundch
Copy link
Member

This is now working with some ad-hoc logic based on the old *.platform library configuration files. We need to later do some cleanup to make it solely depend on the new libraries.json specification file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants