Skip to content

request FunctionTypeImpl._isInstantiated promotion to public interface #30998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jcollins-g opened this issue Oct 4, 2017 · 2 comments
Open

request FunctionTypeImpl._isInstantiated promotion to public interface #30998

jcollins-g opened this issue Oct 4, 2017 · 2 comments
Labels
analyzer-api Issues that impact the public API of the analyzer package area-dart-model For issues related to conformance to the language spec in the parser, compilers or the CLI analyzer. P4 type-enhancement A request for a change that isn't a bug

Comments

@jcollins-g
Copy link
Contributor

jcollins-g commented Oct 4, 2017 •
edited
Loading

FunctionTypeImpl._isInstantiated being a public member of FunctionType would enable dartdoc to avoid fragile heuristics to guess whether a type is instantiated or not. With dart-lang/dartdoc#1509 the heuristic is improved, but I'd prefer to get rid of it entirely.
@jcollins-g jcollins-g added the legacy-area-analyzer Use area-devexp instead. label Oct 4, 2017
@bwilkerson
Copy link
Member

That seems reasonable, but if it can wait I'd like to do that as part of re-working the analyzer APIs to account for Dart 2 semantics. That way we can be sure we have a simple and consistent API.

@jcollins-g jcollins-g changed the title request FunctionTypeImpl._isInitialized promotion to public interface request FunctionTypeImpl._isInstantiated promotion to public interface Oct 4, 2017
@jcollins-g
Copy link
Contributor Author

It can wait, I've found a workaround for now.

@jcollins-g jcollins-g mentioned this issue Oct 10, 2017
Closed
@bwilkerson bwilkerson added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug labels Feb 2, 2018
@srawlins srawlins added P4 and removed P2 A bug or feature request we're likely to work on labels Oct 11, 2023
@srawlins srawlins added the analyzer-api Issues that impact the public API of the analyzer package label Jul 19, 2024
@johnniwinther johnniwinther added area-dart-model For issues related to conformance to the language spec in the parser, compilers or the CLI analyzer. and removed legacy-area-analyzer Use area-devexp instead. labels Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
analyzer-api Issues that impact the public API of the analyzer package area-dart-model For issues related to conformance to the language spec in the parser, compilers or the CLI analyzer. P4 type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@srawlins @bwilkerson @johnniwinther @jcollins-g