Skip to content

move all uses of metadata to the corresponding output unit #31033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sigmundch opened this issue Oct 6, 2017 · 1 comment
Closed

move all uses of metadata to the corresponding output unit #31033

sigmundch opened this issue Oct 6, 2017 · 1 comment

Comments

@sigmundch
Copy link
Member

Historically all metadata emitted for mirrors and Function.apply has been emitted in the main output unit.

To fix #30002, we are moving metadata of function parameters to the same output unit where the function is emitted.

We should consider doing the same for all other metadata. However, a lot of the additional metadata requires complex changes and, if it is only used for dart:mirrors, we might be able to do have a simpler fix after #30538 is addressed.

@sigmundch
Copy link
Member Author

Closing this - I believe I had misunderstood where the changes needed to happen, and it's possible that this is now handled by the changes in https://dart-review.googlesource.com/9140. We can reopen this bug if we discover any issues regarding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant