Skip to content

Incorrect handling of function types in VM's Kernel FE #31214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sjindel-google opened this issue Oct 24, 2017 · 1 comment
Closed

Incorrect handling of function types in VM's Kernel FE #31214

sjindel-google opened this issue Oct 24, 2017 · 1 comment
Assignees
@sjindel-google
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. front-end-kernel legacy-area-front-end Legacy: Use area-dart-model instead.

Comments

@sjindel-google
Copy link
Contributor

The Kernel FE for the VM does not set up parent pointers for signature functions representing function types.

This makes it impossible to finalize type parameters on generic function types, ClassFinalizer::FinalizeType needs to be able to traverse the chain of enclosing functions to compute their indices.

Unfotunately, issue #31213 makes it difficult to test this case.
@sjindel-google sjindel-google added front-end-fasta area-kernel area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. and removed front-end-fasta labels Oct 24, 2017
@sjindel-google
Copy link
Contributor Author

https://dart-review.googlesource.com/c/sdk/+/16360

@sjindel-google sjindel-google self-assigned this Oct 25, 2017
@kmillikin kmillikin added legacy-area-front-end Legacy: Use area-dart-model instead. front-end-kernel and removed legacy-area-front-end Legacy: Use area-dart-model instead. labels Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjindel-google sjindel-google

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. front-end-kernel legacy-area-front-end Legacy: Use area-dart-model instead.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kmillikin @sjindel-google