Skip to content

Rewrite DartAPI_LazyLoadDeoptimizes for Dart 2 #33043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bkonyi opened this issue May 3, 2018 · 2 comments
Closed

Rewrite DartAPI_LazyLoadDeoptimizes for Dart 2 #33043

bkonyi opened this issue May 3, 2018 · 2 comments
Assignees
@bkonyi
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Milestone
Dart 2.1.1

Comments

@bkonyi
Copy link
Contributor

bkonyi commented May 3, 2018

The current implementation is using Dart_LoadSource, which is not supported in Dart 2 in its current form.
@bkonyi bkonyi added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label May 3, 2018
@bkonyi bkonyi added this to the Dart2Stable milestone May 3, 2018
@bkonyi bkonyi self-assigned this May 3, 2018
@bkonyi bkonyi mentioned this issue May 3, 2018
Closed
@bkonyi bkonyi modified the milestones: Dart2Stable, Dart2.1 Jun 15, 2018
@bkonyi
Copy link
Contributor Author

bkonyi commented Aug 20, 2018

If we decide we no longer want to pretend that we support deferred loading (see #33118) we might be able to just remove this test. Otherwise, we might be able to use Dart_LoadScriptFromKernel or something similar.

@bkonyi
Copy link
Contributor Author

bkonyi commented Sep 4, 2018

No plans to update support for deferred loading in the VM at this time. I don't think it's likely that this will change anytime soon, so closing this for now.

@bkonyi bkonyi closed this as completed Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkonyi bkonyi

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Milestone
Dart 2.1.1
Development

No branches or pull requests
1 participant
@bkonyi