Skip to content

Patching mechanism in CFE doesn't allow to patch members with members of a different kind #33495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chloestefantsova opened this issue Jun 19, 2018 · 5 comments
Assignees
Labels
legacy-area-front-end Legacy: Use area-dart-model instead. P2 A bug or feature request we're likely to work on
Milestone

Comments

@chloestefantsova
Copy link
Contributor

Currently both factories and redirecting factories are represented as Procedures in Kernel. The latter has special bodies that encode the redirection information, that is, the target constructor and the type arguments. There's also a specialized subclass of Member to represent redirecting factories, namely RedirectingFactoryConstructor.

Now, some platform-specific patches to core libraries patch non-redirecting factories with redirecting factories. It does work currently, as both are represented as Procedures, but it doesn't work when we try to change the representation of redirecting factories to the specialized one.

The patching mechanism needs to be update to work in that case.

@mit-mit
Copy link
Member

mit-mit commented Jul 9, 2018

Punting to 2.1 per comment in #29989 (comment) that this is not critical for stable

@mit-mit mit-mit modified the milestones: Dart2Stable, Dart2.1 Jul 9, 2018
@kmillikin
Copy link

This is unrelated to the Dart 2.1 release.

@kmillikin kmillikin modified the milestones: Dart2.1, PostDart2.1 Oct 9, 2018
@a-siva a-siva modified the milestones: PostDart2.1, Dart2.2 Oct 9, 2018
@vsmenon vsmenon modified the milestones: Dart2.2, Dart2.3 Mar 14, 2019
@vsmenon
Copy link
Member

vsmenon commented Mar 14, 2019

Note, this is blocking another 2.3 issue.

@dgrove
Copy link
Contributor

dgrove commented Mar 16, 2019

Specifically, this blocks #33041

@a-siva
Copy link
Contributor

a-siva commented Mar 21, 2019

I think we can punt this to 2.4 we realize the front end team is busy and we have lived with #33041 for almost a year now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy-area-front-end Legacy: Use area-dart-model instead. P2 A bug or feature request we're likely to work on
Projects
None yet
Development

No branches or pull requests

8 participants