Skip to content

dart2js: ReferenceError in parameter. #3536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rakudrama opened this issue Jun 11, 2012 · 4 comments
Closed

dart2js: ReferenceError in parameter. #3536

rakudrama opened this issue Jun 11, 2012 · 4 comments
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js

Comments

@rakudrama
Copy link
Member

  1. Uncomment suppression for html/fileapi_test
  2. ./tools/test.py -m release -c dart2js -r drt html/fileapi_test

CONSOLE MESSAGE: line 7735: Uncaught ReferenceError: errorCallback is not defined

The problem appears to the the attempt in webkitRequestFileSystem$3 to overwrite a parameter that does not exist in that version of the shim.

$.$defineNativeClass('DOMWindow', ["navigator?", "name?", "length?"], {
 webkitRequestFileSystem$4: function(type, size, successCallback, errorCallback) {
  return this.webkitRequestFileSystem(type,size,$.convertDartClosureToJS(successCallback, 1),$.convertDartClosureToJS(errorCallback, 1));
 },
 webkitRequestFileSystem$3: function(type,size,successCallback) {
  successCallback = $.convertDartClosureToJS(successCallback, 1);
  errorCallback = $.convertDartClosureToJS(errorCallback, 1); // HERE
  return this.webkitRequestFileSystem(type,size,successCallback);
},

@kasperl
Copy link

kasperl commented Jun 12, 2012

Set owner to [email protected].
Removed Priority-Medium label.
Added Priority-High, Accepted labels.

@DartBot
Copy link

DartBot commented Jun 12, 2012

This comment was originally written by [email protected]


Fixed in https://chromiumcodereview.appspot.com/10539109


Added Fixed label.

@sethladd
Copy link
Contributor

Marked this as blocking #3022.

@DartBot
Copy link

DartBot commented Aug 17, 2012

This comment was originally written by [email protected]


How can this be blocking #­3022 since this bug is fixed? Does the same problem show up in another case?

@rakudrama rakudrama added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js labels Aug 17, 2012
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js
Projects
None yet
Development

No branches or pull requests

4 participants