Skip to content

Move Platform (or similar) to dart:core #37713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vsmenon opened this issue Aug 1, 2019 · 1 comment
Closed

Move Platform (or similar) to dart:core #37713

vsmenon opened this issue Aug 1, 2019 · 1 comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. customer-flutter library-core

Comments

@vsmenon
Copy link
Member

vsmenon commented Aug 1, 2019

A primary reason for Flutter apps to import dart:io is to access the Platform class.

Moving this class to dart:core (or some other shared library) would simplify development for Flutter Web.

FYI - @lrhn @ferhatb @jonahwilliams @kevmoo

If we do this, we'd need to understand what these APIs should return on the Web:

https://api.dartlang.org/dev/2.5.0-dev.1.0/dart-io/Platform-class.html

E.g., does Platform.isAndroid mean native Android or would it also be true for Android Chrome, etc.

@vsmenon vsmenon added area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-core customer-flutter labels Aug 1, 2019
@vsmenon
Copy link
Member Author

vsmenon commented Aug 1, 2019

Actually, let me close this in favor of:

#35969

and retitle / label that one.

@vsmenon vsmenon closed this as completed Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. customer-flutter library-core
Projects
None yet
Development

No branches or pull requests

1 participant