Skip to content

Refactor Cross-Frame DOM Classes #3836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vsmenon opened this issue Jun 22, 2012 · 7 comments
Closed

Refactor Cross-Frame DOM Classes #3836

vsmenon opened this issue Jun 22, 2012 · 7 comments
Assignees
@vsmenon
Labels
web-libraries Issues impacting dart:html, etc., libraries
Milestone
M1

Comments

@vsmenon
Copy link
Member

vsmenon commented Jun 22, 2012

Refactor all dart:html classes with cross-frame variants: Window, Location, History. The base type should be the more restrictive class, only with methods that accessible from a different frame.

The global window object will be a sub-class with everything.

Ensure that any method that returns a Window/Location/History returns the cross-frame variant unless it corresponds to your own window.
@vsmenon
Copy link
Member Author

vsmenon commented Jun 22, 2012

Issue #2774 has been merged into this issue.

cc @jacob314.

@vsmenon
Copy link
Member Author

vsmenon commented Jun 22, 2012

Issue #3175 has been merged into this issue.

cc @kasperl.

@vsmenon
Copy link
Member Author

vsmenon commented Jun 22, 2012

Issue #1173 has been merged into this issue.

@vsmenon
Copy link
Member Author

vsmenon commented Jul 16, 2012

Marked this as blocking #2758.

@vsmenon
Copy link
Member Author

vsmenon commented Jul 16, 2012

Set owner to @vsmenon.

@iposva-google
Copy link
Contributor

Removed Area-DOM label.
Added Area-HTML label.

@vsmenon
Copy link
Member Author

vsmenon commented Oct 5, 2012

Fixed. The base types - Window, Location, and History - now provided a more restricted API. The local variants (including the global window) are LocalWindow, LocalLocation, and LocalHistory.

Added Fixed label.

@vsmenon vsmenon added Type-Defect web-libraries Issues impacting dart:html, etc., libraries labels Oct 5, 2012
@vsmenon vsmenon self-assigned this Oct 5, 2012
@vsmenon vsmenon added this to the M1 milestone Oct 5, 2012
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

Labels
web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Milestone
M1
Development

No branches or pull requests
2 participants
@vsmenon @iposva-google