Skip to content

Allow renaming JS interop members #39056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
natebosch opened this issue Oct 22, 2019 · 2 comments
Open

Allow renaming JS interop members #39056

natebosch opened this issue Oct 22, 2019 · 2 comments
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. P2 A bug or feature request we're likely to work on web-js-interop Issues that impact all js interop

Comments

@natebosch
Copy link
Member

Today we silently ignore string in @JS() annotations on members. The JS member and the dart member must share the same name.

In the short term we should have a static error for this.

In the long term we should support renames. Support may be blocked on disallowing extending or implementing JS interop types: #37896
@natebosch natebosch added area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. web-js-interop Issues that impact all js interop labels Oct 22, 2019
@a14n
Copy link
Contributor

a14n commented Oct 24, 2019

Dup of #24779 ?

Particularly see #24779 (comment) which will be awesome to address.

@vsmenon vsmenon added the P2 A bug or feature request we're likely to work on label Oct 28, 2019
@vsmenon
Copy link
Member

vsmenon commented Oct 28, 2019

Marking as P2 for at least the static error for what is broken now.

@natebosch natebosch mentioned this issue Oct 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. P2 A bug or feature request we're likely to work on web-js-interop Issues that impact all js interop
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@a14n @vsmenon @natebosch