Feature request: "Change Signature" refactoring

[saif97]

This is my very first time posting issue on GitHub, so excuse me if I did it wrong
IntelliJ idea has a really cool and time-saving refactoring method signatures feature. Unfortunately, for some reason, it doesn't work in IntelliJ Idea.

I've found this issue in IntelliJ's YouTrack 4 years ago which redirected me here.

Flutter 1.12.13+hotfix.5 • channel stable •
https://github.com/flutter/flutter.git
Framework • revision 27321ebbad (7 days ago) •
2019-12-10 18:15:01 -0800
Engine • revision 2994f7e1e6
Tools • Dart 2.7.0

Using Windows, chrome.

[devoncarew]

@saif97 - thanks for the feedback. To clarify - is this a bug report or a feature request?

[devoncarew]

cc @jwren

[jwren]

Are all Dart refactorings (Shift + F6 action) in IntelliJ broken? Does a dialog appear after you invoke the refactoring? Is an exception thrown?, or does the refactoring just not happen?

[saif97]

@saif97 - thanks for the feedback. To clarify - is this a bug report or a feature request?

Feature request I guess. The feature is already available in IntelliJ Idea for Java development. However, It doesn't work for Dart.

Are all Dart refactorings (Shift + F6 action) in IntelliJ broken? Does a dialog appear after you invoke the refactoring? Is an exception thrown? or does the refactoring just not happen?

These are all the available refactoring options for Dart. They all work (Thank you guys for the amazing work).
However, the Change signature isn't available in Dart. The picture below shows Java Code where pressing Ctrl + F6 (in my case) or simply searching it shows the command

In this picture, I tried to do the same in Dart code but as you can see the command isn't there & pressing Ctrl + F6 doesn't show the window either.

No exceptions are thrown.

[jwren]

Changed to a feature request. I am glad the refactorings are working as expected. This is just not one of the refactorings that we happen to offer.

https://htmlpreview.github.io/?https://github.com/dart-lang/sdk/blob/master/pkg/analysis_server/doc/api.html#type_RefactoringKind

@scheglov @bwilkerson

[alexander-doroshko]

@devoncarew Probably area-analyzer?

[vrnvorona]

Any updates?

[filipagh]

can you also include scope of move refactor to class, function ... (not only file) (idea shortcut F6)
expected result (python)

actual options

thanks

[prinkeeras]

any updates on this?

[bwilkerson]

Nothing concrete.

We are hope to have some time this quarter to work on improving our refactoring support, but we haven't yet decided which refactorings we will be adding. This refactoring is definitely on our radar, though there are some limitations in LSP that might require us to implement a set of smaller refactorings that together could be used to achieve the same effect. That might not be ideal, but might be better than no support. We'll know more after we've had time to investigate what's possible and what isn't.

[bwilkerson]

There have been a couple of refactorings added since I last commented. They are, unfortunately, not available in IntelliJ at this point, but are available in VS Code.

There is now a 'Move to file' refactoring to help re-organize code in libraries.

There are also some experimental refactorings to convert some or all of the positional parameters to be named parameters and to move parameters left in the parameter list. Both implement a portion of the kinds of changes that a 'Change signature' refactoring would be expected to make, but can be done without implementing a per-client dialog.

It's unlikely that we'll be able to provide the full-functioned refactoring asked for here, as much as we'd like to. So, as much as I don't want to, I'm going to close this issue.

If there are other small-grained refactorings like these that you would like us to add, please open an issue for each of them.