Skip to content

Converting previously error diagnostics to warnings breaks several tests #42650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
scheglov opened this issue Jul 9, 2020 · 4 comments
Closed

Converting previously error diagnostics to warnings breaks several tests #42650

scheglov opened this issue Jul 9, 2020 · 4 comments
Assignees
@scheglov
Labels
legacy-area-analyzer Use area-devexp instead. NNBD Issues related to NNBD Release

Comments

@scheglov
Copy link
Contributor

scheglov commented Jul 9, 2020

See https://dart-ci.firebaseapp.com/cl/153742/1

language_2/super/setter_test
language_2/unsorted/index_assign_operator_infer_return_type_test

language/unsorted/index_assign_operator_infer_return_type_test

See also dart-lang/co19#805
@scheglov scheglov added legacy-area-analyzer Use area-devexp instead. NNBD Issues related to NNBD Release labels Jul 9, 2020
@scheglov scheglov self-assigned this Jul 9, 2020
@eernstg
Copy link
Member

eernstg commented Jul 9, 2020

Please note that I'm gathering support for changing several specified warnings to errors, in which case there is no need to change the analyzer in the opposite direction: dart-lang/language#1012.

@scheglov
Copy link
Contributor Author

scheglov commented Jul 9, 2020

OK, I will postpone landing my CL.
I started looking on issues because of our progress report for "NNBD regressions" in analyzer was not moving into the right direction :-)

@eernstg
Copy link
Member

eernstg commented Jul 9, 2020

I hope I can soon make this move without any effort from you! ;-)

@scheglov
Copy link
Contributor Author

scheglov commented Aug 1, 2020

OK, there is nothing to do here then.

@scheglov scheglov closed this as completed Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
legacy-area-analyzer Use area-devexp instead. NNBD Issues related to NNBD Release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scheglov @eernstg