Skip to content

[CP] merge into [beta] channel: disallows imports to dart:mirrors on the web #42715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sigmundch opened this issue Jul 16, 2020 · 3 comments
Closed
Labels
cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-beta

Comments

@sigmundch
Copy link
Member

sigmundch commented Jul 16, 2020

commit(s) to merge: c632a62

merge instructions: clean merge

what's the problem:

In 2.8 there is a static error on web compilers (dart2js and ddc) when apps import dart:mirrors. This was unintended (bug #42475).

In 2.9-beta this error is gone. We debated removing the error in 2.8 (#42553) and decided to embrace the breaking change instead (#42714) and readd the error to 2.9 (c632a62)

why cherry-pick:

We want to avoid being inconsistent: no error in 2.7, error in 2.8, no error in 2.9, error in 2.10. To prevent that, we'd like to cherry-pick this change to 2.9-beta and eventually 2.9 stable.

Note: since 2.8 already has this breaking change, this cherry-pick is effectively only improving the error message, it shouldn't affect anything that the 2.8 breaking change didn't before.

/cc @kevmoo @mit-mit @whesse @athomas @vsmenon @franklinyow

@franklinyow
Copy link
Contributor

scrum team approved

@franklinyow
Copy link
Contributor

@pcsosinski @whesse

@whesse
Copy link
Contributor

whesse commented Jul 21, 2020

Cherry-picked to 2.9.0-21.10.beta.

@whesse whesse closed this as completed Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-beta
Projects
None yet
Development

No branches or pull requests

3 participants