Skip to content

Proposed as expressions with needlessly nullable type #44232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johnniwinther opened this issue Nov 17, 2020 · 2 comments
Closed

Proposed as expressions with needlessly nullable type #44232

johnniwinther opened this issue Nov 17, 2020 · 2 comments
Labels
area-migration (deprecated) Deprecated: this label is no longer actively used (was: issues with the `dart migrate` tool). P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@johnniwinther
Copy link
Member

When migrating

Class get enclosingClass => parent is Class ? parent : null;

the proposed edit was added an as Class?:

Class? get enclosingClass => parent is Class ? parent as Class? : null;
                                                      ^^^^^^^^^

and not the more precise as Class:

Class? get enclosingClass => parent is Class ? parent as Class : null;
                                                      ^^^^^^^^
@johnniwinther johnniwinther added type-enhancement A request for a change that isn't a bug pkg-migration labels Nov 17, 2020
@stereotype441 stereotype441 added the area-migration (deprecated) Deprecated: this label is no longer actively used (was: issues with the `dart migrate` tool). label Nov 17, 2020
@stereotype441
Copy link
Member

This is another issue with the migration tool being too cautious because of the lack of field promotion. Should be addressed by #40566.

@stereotype441 stereotype441 added P2 A bug or feature request we're likely to work on and removed pkg-migration labels Nov 17, 2020
@franklinyow franklinyow modified the milestones: Future, December 2020 Nov 18, 2020
@stereotype441
Copy link
Member

As of 1c7fe71, the null safety migration tool has been removed from active development and retired. No further work on the tool is planned.

If you still need help, or you believe this issue has been closed in error, please feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-migration (deprecated) Deprecated: this label is no longer actively used (was: issues with the `dart migrate` tool). P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants