Skip to content

[CP] [Beta] Revert "[cfe] Handle conditional await in CFE" #44827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
a-siva opened this issue Feb 2, 2021 · 2 comments
Closed

[CP] [Beta] Revert "[cfe] Handle conditional await in CFE" #44827

a-siva opened this issue Feb 2, 2021 · 2 comments
Assignees
Labels
cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-beta

Comments

@a-siva
Copy link
Contributor

a-siva commented Feb 2, 2021

Please cherry pick 34f9734 into the beta branch

Reason : We had some test failures after this change was rolled into Flutter, please see
flutter/flutter#75155

@dnfield has verified that the original CL has caused the test breakage.

The change does not merge cleanly into the beta branch, a CL with the merge conflicts resolved has been
created at https://dart-review.googlesource.com/c/sdk/+/182200

Risk: The intended spec change proposed in #44395 will not happen
stability risk is low, the revert has been merged into master and rolled into Flutter Engine.

Link to original issue flutter/flutter#75155

/cc @kevmoo @mit-mit @whesse @athomas @vsmenon @franklinyow @leafpetersen @sigmundch

@a-siva a-siva added merge-to-beta cherry-pick-review Issue that need cherry pick triage to approve labels Feb 2, 2021
@a-siva a-siva added this to the January Beta Release (2.12) milestone Feb 2, 2021
@franklinyow franklinyow added the cherry-pick-approved Label for approved cherrypick request label Feb 2, 2021
@franklinyow
Copy link
Contributor

I'm approving this, I believe there are enough eyes on this one.

@athomas
Copy link
Member

athomas commented Feb 2, 2021

Merged to beta with e5dd92c (2.12.0-259.8.beta).

@athomas athomas closed this as completed Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-beta
Projects
None yet
Development

No branches or pull requests

3 participants