Skip to content

dart2js: cleanup after >>> is enabled by default #45335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
sigmundch opened this issue Mar 16, 2021 · 6 comments
Closed
2 tasks done

dart2js: cleanup after >>> is enabled by default #45335

sigmundch opened this issue Mar 16, 2021 · 6 comments
Assignees
@rakudrama
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. P2 A bug or feature request we're likely to work on web-dart2js
Milestone
July release (Dar...

Comments

@sigmundch
Copy link
Member

sigmundch commented Mar 16, 2021 •
edited by rakudrama
Loading

See #30890 (comment):

  • remove triple-shift flags added to the codegen and optimization tests
  • run dartfmt on the test code containing >>>.
@sigmundch sigmundch added web-dart2js P2 A bug or feature request we're likely to work on area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. labels Mar 16, 2021
@sigmundch sigmundch added this to the March Beta Release milestone Mar 16, 2021
@sigmundch
Copy link
Member Author

FYI @rakudrama - this may be unblocked since 9443e24

@rakudrama
Copy link
Member

Still need analyzer/dartfmt to refault to triple-shift.

@franklinyow
Copy link
Contributor

The small features implementation is done.

@vsmenon
Copy link
Member

vsmenon commented Aug 4, 2021

@sigmundch - this is in the July milestone - can we close now?

@sigmundch
Copy link
Member Author

Not sure, @rakudrama - is it possible to do the cleanup at this time? Or do we need to wait until the feature hits stable?

@rakudrama
Copy link
Member

There are now no dart2js-specific files that need reformatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rakudrama rakudrama

Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. P2 A bug or feature request we're likely to work on web-dart2js
Projects
None yet
Milestone
July release (Dart 2.14 beta + stable...
Development

No branches or pull requests
4 participants
@sigmundch @rakudrama @vsmenon @franklinyow