Skip to content

apidoc during build step is terribly slow #4579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dgrove opened this issue Aug 17, 2012 · 16 comments
Closed

apidoc during build step is terribly slow #4579

dgrove opened this issue Aug 17, 2012 · 16 comments
Assignees
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. closed-obsolete Closed as the reported issue is no longer relevant

Comments

@dgrove
Copy link
Contributor

dgrove commented Aug 17, 2012

There are two parts to this:

  1. apidoc appears to run when it doesn't need to - there must be something wrong with its dependencies.
  2. apidoc itself is extremely slow these days.
@dgrove
Copy link
Contributor Author

dgrove commented Aug 17, 2012

Added this to the M1 milestone.

@sethladd
Copy link
Contributor

When profiling apidoc, please check IO performance. We used to generate "dynamic" docs, which results in less bytes written to the file system. However, the downside is that it results in slower page loads. We now generate "static" docs, so our api.dartlang.org pages load much faster now.

Also, what does "terribly slow" mean?

@jmesserly
Copy link

As Lars said: "
It now takes more than 20 minutes to generate the api docs.
Please look into it. The task is part of tools/build.py -m debug.
Using the release VM "only" takes 1:39. It might be a VM issue.
"

20 minute is terribly slow :)

In general I don't think we want to run tools on the debug VM.

@DartBot
Copy link

DartBot commented Aug 22, 2012

This comment was originally written by [email protected]


Does anyone want to speak in favor of having build.py run apidoc on the checked-mode VM?

My understanding is that

  1. build.py runs apidoc to expose apidoc breaks,
  2. those are less common now that apidoc uses dart2js machinery,
  3. we aren't aware of needing coverage for breakage specific to checked mode, though it could happen.

@munificent
Copy link
Member

I'm OK with disabling the apidoc build step in debug mode.

@sethladd
Copy link
Contributor

sethladd commented Sep 3, 2012

Did this get resolved? I remember the VM guys tweaks some code that sped this up.


cc @iposva-google.

@dgrove
Copy link
Contributor Author

dgrove commented Oct 10, 2012

Some improvements have been made here, but there's still more to do for M2.


cc @rakudrama.
Set owner to @dgrove.
Removed this from the M1 milestone.
Added this to the M2 milestone.

@anders-sandholm
Copy link
Contributor

Removed this from the M2 milestone.
Added this to the M3 milestone.

@anders-sandholm
Copy link
Contributor

Removed this from the M3 milestone.
Added this to the M4 milestone.

@larsbak
Copy link

larsbak commented May 28, 2013

Removed this from the M4 milestone.
Added this to the M5 milestone.

@ricowind
Copy link
Contributor

We don't do that anymore right, should this be closed

@anders-sandholm
Copy link
Contributor

Removed Area-Build label.
Added Area-Infrastructure label.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the M5 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@ricowind
Copy link
Contributor

ricowind commented Jun 2, 2015

Added AssumedStale label.

@dgrove dgrove added Type-Defect area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. closed-obsolete Closed as the reported issue is no longer relevant labels Jun 2, 2015
@dgrove dgrove self-assigned this Jun 2, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. closed-obsolete Closed as the reported issue is no longer relevant
Projects
None yet
Development

No branches or pull requests

9 participants