Skip to content

Uint64List should acknowledge that int is signed #46498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hixie opened this issue Jun 28, 2021 · 2 comments
Open

Uint64List should acknowledge that int is signed #46498

Hixie opened this issue Jun 28, 2021 · 2 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-typed-data type-documentation A request to add or improve documentation

Comments

@Hixie
Copy link
Contributor

Hixie commented Jun 28, 2021

The Uint64 list docs (https://api.flutter.dev/flutter/dart-typed_data/Uint64List-class.html) don't make any mention of the fact that you can't actually get an unsigned int out of a Uint64, since Dart's integers are signed 64 bit.

(It's not really clear to me that we should keep Uint64List at all, actually. As far as I can tell it's not really usable now that we don't have unbounded integers.)

@Hixie
Copy link
Contributor Author

Hixie commented Jun 28, 2021

See also #35225

@mraleph mraleph added the area-documentation Prefer using 'type-documentation' and a specific area label. label Jul 7, 2021
@lrhn
Copy link
Member

lrhn commented Jul 7, 2021

We could consider removing the class entirely (it doesn't exist on the web, so it's already half-way not there).
If we introduce a typedef Uint64List = Int64List;, no-one should be able to tell the difference.

@devoncarew devoncarew added library-typed-data area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. type-documentation A request to add or improve documentation and removed area-documentation Prefer using 'type-documentation' and a specific area label. labels Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-typed-data type-documentation A request to add or improve documentation
Projects
None yet
Development

No branches or pull requests

4 participants