Skip to content

[analyzer] rename doesn't handle String interpolation #47521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asashour opened this issue Oct 21, 2021 · 0 comments
Open

[analyzer] rename doesn't handle String interpolation #47521

asashour opened this issue Oct 21, 2021 · 0 comments
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) devexp-refactoring Issues with analysis server refactorings P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@asashour
Copy link
Contributor

asashour commented Oct 21, 2021

Rename the variable a to a$

String f() {
  var a = '';
  return '$a';
}

The actual result is '$a$', which should be '${a$}'. This happens with both IDEs.

Visual Studio Code calls the server textDocument/rename.

IntelliJ does it by itself. I believe it should also call the server to rename.

Handling special characters was hinted in the discussion around #22038

@vsmenon vsmenon added the legacy-area-analyzer Use area-devexp instead. label Oct 21, 2021
@srawlins srawlins added devexp-refactoring Issues with analysis server refactorings P3 A lower priority bug or feature request labels Oct 22, 2021
@srawlins srawlins added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Nov 16, 2021
@srawlins srawlins added the contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) label May 20, 2022
@bwilkerson bwilkerson added area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. and removed legacy-area-analyzer Use area-devexp instead. labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) devexp-refactoring Issues with analysis server refactorings P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

4 participants