Skip to content

[CP] Deprecation message for dartanalyzer command #48176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mit-mit opened this issue Jan 20, 2022 · 3 comments
Closed

[CP] Deprecation message for dartanalyzer command #48176

mit-mit opened this issue Jan 20, 2022 · 3 comments
Labels
cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve legacy-area-analyzer Use area-devexp instead.

Comments

@mit-mit
Copy link
Member

mit-mit commented Jan 20, 2022

commit(s) to merge: d9b69e9 should be picked into the beta channel

merge instructions: clean merge

What is the issue:

We planned, and announced, that the dartanalyzer command is deprecated in Dart 2.16: #46100

However, there was a mistake in how the deprecation output was added in cr 219702, so the deprecation messages ended up being added to a set of bin files that are only used internally during SDK development, and not in the actual bin/dartanalyzer and bin/dartanalyzer.bat files we ship in the SDK.

The intended output was added to the correct files in cr 229143.

What is the fix: Add simple print statements

Why cherrypick: We already announced the deprecation. If these messages don't go put in 2.16 there is a risk that developers might not realize that this command is deprecated.

Risk: Very low, just adds a print statement.

Link to original issue(s): #46100

/cc @mit-mit @whesse @athomas @vsmenon @devoncarew

@mit-mit mit-mit added the cherry-pick-review Issue that need cherry pick triage to approve label Jan 20, 2022
@mit-mit
Copy link
Member Author

mit-mit commented Jan 20, 2022

Confirmed that the fix from cr 229143 works in a downloaded bleeding edge build (https://storage.googleapis.com/dart-archive/channels/be/raw/latest/sdk/dartsdk-macos-x64-release.zip):

$ ~/tmp/dart-sdk/bin/dartanalyzer
Warning: 'dartanalyzer' is deprecated. Please use 'dart analyze'.
Usage: dartanalyzer [options...] <directory or list of files>

And from current beta:

$ ~/dev/flutter/bin/cache/dart-sdk/bin/dartanalyzer --version
dartanalyzer version 2.16.0-134.1.beta
$ ~/dev/flutter/bin/cache/dart-sdk/bin/dartanalyzer
Usage: dartanalyzer [options...] <directory or list of files>

@mraleph mraleph added the legacy-area-analyzer Use area-devexp instead. label Jan 20, 2022
@devoncarew
Copy link
Member

From the scrum meeting, this is approved.

@devoncarew devoncarew added the cherry-pick-approved Label for approved cherrypick request label Jan 20, 2022
@whesse
Copy link
Contributor

whesse commented Jan 24, 2022

Cherry-picked into 2.16.0-134.5.beta.

@whesse whesse closed this as completed Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve legacy-area-analyzer Use area-devexp instead.
Projects
None yet
Development

No branches or pull requests

4 participants