Skip to content

[Patterns] Dart2js implementation #49754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
itsjustkevin opened this issue Aug 19, 2022 · 8 comments
Closed

[Patterns] Dart2js implementation #49754

itsjustkevin opened this issue Aug 19, 2022 · 8 comments
Assignees
@rakudrama
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. P2 A bug or feature request we're likely to work on web-dart2js
Milestone
Dart 3 stable

Comments

@itsjustkevin
Copy link
Contributor

No description provided.

@a-siva a-siva added the area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. label Aug 19, 2022
@sigmundch sigmundch assigned rakudrama and unassigned sigmundch Aug 22, 2022
@stereotype441 stereotype441 mentioned this issue Nov 30, 2022
Open
@itsjustkevin itsjustkevin added this to the Dart 3 beta 2 milestone Feb 6, 2023
@vsmenon
Copy link
Member

vsmenon commented Feb 23, 2023

@rakudrama - is there anything still open here wrt to functionality?

@rakudrama
Copy link
Member

There are a few failures still because the front-end generates identifiers with strange names.

@rakudrama
Copy link
Member

These CLs are out for review to fix two 'crash' issues in the milestone.
https://dart-review.googlesource.com/c/sdk/+/293162
https://dart-review.googlesource.com/c/sdk/+/293164

@vsmenon vsmenon added the P2 A bug or feature request we're likely to work on label Apr 4, 2023
@leafpetersen
Copy link
Member

Moving this to the stable milestone, since I believe anything further will be cherry picked. Feel free to close if we think this is done.

@rakudrama
Copy link
Member

I think we are done.

@vsmenon
Copy link
Member

vsmenon commented Apr 7, 2023

Is there anything we need to cherry-pick?

@rakudrama
Copy link
Member

Is there anything we need to cherry-pick?

Not yet ;-)
The changes that were hot on the deadline made it it. The remaining failing tests are all for the usual 'production mode' reasons - tests that fail to throw just because -O3 omits checks.

@vsmenon
Copy link
Member

vsmenon commented Apr 7, 2023

Great, thanks @rakudrama !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rakudrama rakudrama

Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. P2 A bug or feature request we're likely to work on web-dart2js
Projects
None yet
Milestone
Dart 3 stable
Development

No branches or pull requests
6 participants
@sigmundch @rakudrama @vsmenon @leafpetersen @a-siva @itsjustkevin