Skip to content

[CP] Fix dart run resolution on dev-releases #50625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sigurdm opened this issue Dec 5, 2022 · 5 comments
Closed

[CP] Fix dart run resolution on dev-releases #50625

sigurdm opened this issue Dec 5, 2022 · 5 comments
Assignees
@vsmenon @whesse @itsjustkevin @mit-mit @athomas
Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-beta

Comments

@sigurdm
Copy link
Contributor

sigurdm commented Dec 5, 2022 •
edited
Loading

Commit(s) to merge

258598e

Target

2.19 beta and forward

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/273743

Issue Description

dart run will do a full resolution every time if your current sdk is a dev-release.
Causing unnecessary churn.

See eg. #50617

What is the fix

Removing the logic that would consider a resolution stale if it is a dev-release.

Why cherry-pick

All users of dart run on beta releases.

Risk

low

Issue link(s)

See eg. #50617

Extra Info

This bug affects only sdk's that are themselves dev-releases.
But as any beta-release is also a dev-release we should better fix it.

Only the https://dart.googlesource.com/pub.git/+/04f7bce8 commit is needed for this, but the other commits are either minor or themselves reverted, and seem low-risk.
@sigurdm sigurdm added the cherry-pick-review Issue that need cherry pick triage to approve label Dec 5, 2022
@sigurdm sigurdm changed the title [CP] <title> [CP] Fix dart run resolution on dev-releases Dec 5, 2022
@itsjustkevin
Copy link
Contributor

@athomas and @jonasfj can you take a look a this cherry-pick?

@jonasfj
Copy link
Member

jonasfj commented Dec 5, 2022 •
edited
Loading

LGTM, while the bug only affects prerelease versions of the Dart SDK. It will affect all the beta releases, and thus, in theory could hide other issues that would otherwise show up in the betas.

@sigurdm
Copy link
Contributor Author

sigurdm commented Dec 5, 2022

Here is the diff of pub that this includes:
https://dart.googlesource.com/pub.git/+/4fd2051bb8060ea2f2e02b13dfeb2f793d197994..21aa23f148a428ae4dd97a27ecc70b08c1328089/

@kevmoo kevmoo added the area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. label Dec 7, 2022
@itsjustkevin itsjustkevin added the cherry-pick-approved Label for approved cherrypick request label Dec 7, 2022
@sigurdm sigurdm mentioned this issue Dec 8, 2022
Closed
@vsmenon
Copy link
Member

vsmenon commented Dec 12, 2022

lgtm

@itsjustkevin
Copy link
Contributor

Merged into 2.19.0-444.2.beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@whesse whesse

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-beta
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@kevmoo @jonasfj @vsmenon @whesse @sigurdm @itsjustkevin @mit-mit @athomas