Skip to content

[CP] cherry-pick linter 1.31.0 #50663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pq opened this issue Dec 8, 2022 · 3 comments
Closed

[CP] cherry-pick linter 1.31.0 #50663

pq opened this issue Dec 8, 2022 · 3 comments
Assignees
@vsmenon @whesse @itsjustkevin @mit-mit @athomas
Labels
cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve

Comments

@pq
Copy link
Member

pq commented Dec 8, 2022

Commit(s) to merge

d5c1158, 636eec1

Target

beta

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/274481

Issue Description

Linter 1.30.0 has two issues w/ 2.19:

  1. the recommended lint prefer_equal_for_default_values will double-report where there is newly introduced analyzer diagnostic
  2. the core lint unrelated_type_equality_checks generates false positives in the updated package:fixnum

What is the fix

Lands linter 1.31.0 that:

  1. updates prefer_equal_for_default_values to not report for SDKs >=2.19
  2. updates unrelated_type_equality_checks for the package:fixnum restructuring

Why cherry-pick

Users of 2.19 will see lint noise.

(Note that these changes landed on Tuesday, before the feature cut-off, so really aren't cherry-picks. 🤷 )

/fyi @devoncarew

Risk

low

Issue link(s)

#58939, #58936

Extra Info

No response
@pq pq added the cherry-pick-review Issue that need cherry pick triage to approve label Dec 8, 2022
@mit-mit
Copy link
Member

mit-mit commented Dec 8, 2022

SGTM, this was causing analysis in package:fixnum in the beta channel.

@itsjustkevin itsjustkevin added the cherry-pick-approved Label for approved cherrypick request label Dec 12, 2022
@vsmenon
Copy link
Member

vsmenon commented Dec 12, 2022

lgtm

@pq
Copy link
Member Author

pq commented Dec 12, 2022

Fixed w/ https://dart-review.googlesource.com/c/sdk/+/274481.

@pq pq closed this as completed Dec 12, 2022
@devoncarew devoncarew mentioned this issue Dec 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@whesse whesse

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@pq @vsmenon @whesse @itsjustkevin @mit-mit @athomas