Skip to content

[Class modifiers] DDC implementation #50731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
itsjustkevin opened this issue Dec 15, 2022 · 4 comments
Closed

[Class modifiers] DDC implementation #50731

itsjustkevin opened this issue Dec 15, 2022 · 4 comments
Assignees
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. P2 A bug or feature request we're likely to work on web-dev-compiler
Milestone

Comments

@itsjustkevin
Copy link
Contributor

No description provided.

@munificent munificent changed the title [NCM] DDC implementation [Class modifiers] DDC implementation Dec 17, 2022
@lrhn lrhn added web-dev-compiler area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. labels Dec 20, 2022
@nshahan
Copy link
Contributor

nshahan commented Jan 13, 2023

Currently we don't expect any implementation needed on our side to support the feature. Leaving this open until we have a better test suite and know there are no new AST nodes any new patterns are working as expected.

This feature could unlock some changes to how we compile code if we have a better idea of what classes are actually mixed-in. I'm excited to investigate more in the future.

@nshahan nshahan added the P2 A bug or feature request we're likely to work on label Jan 13, 2023
@itsjustkevin itsjustkevin added this to the Dart 3 beta 2 milestone Feb 6, 2023
@kallentu
Copy link
Member

@nshahan fyi, classes can no longer be mixed in (anywhere, in or out of library) in Dart 3 unless they are using the mixin modifier. So only mixin classes and mixins can be mixed in.
Not sure if that changes anything on the DDC side.

But besides that, there are no runtime semantics so I don't think there's any work needed on the DDC.

@nshahan
Copy link
Contributor

nshahan commented Feb 22, 2023

🎉 🍾 🎊 I saw that and I am so happy!

This will unlock some changes that we can make in DDC but nothing required for Dart 3. I have ideas that will allow us to simplify our handling of mixins and fix some correctness bugs that have been around for a long time.

@nshahan
Copy link
Contributor

nshahan commented Mar 7, 2023

With the completion of #50727 I still don't see any issues on the DDC side. I'm closing this with the understanding that we don't need to handle anything new from the CFE for this feature.

@nshahan nshahan closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. P2 A bug or feature request we're likely to work on web-dev-compiler
Projects
None yet
Development

No branches or pull requests

4 participants