Skip to content

[Sealed class] Analysis server / IDE support work #51291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #51278
itsjustkevin opened this issue Feb 6, 2023 · 4 comments
Closed
Tracked by #51278

[Sealed class] Analysis server / IDE support work #51291

itsjustkevin opened this issue Feb 6, 2023 · 4 comments
Assignees
Labels
devexp-server Issues related to some aspect of the analysis server legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Milestone

Comments

@itsjustkevin
Copy link
Contributor

No description provided.

@srawlins
Copy link
Member

srawlins commented Feb 6, 2023

CC @kallentu @bwilkerson

@srawlins srawlins added legacy-area-analyzer Use area-devexp instead. devexp-server Issues related to some aspect of the analysis server type-enhancement A request for a change that isn't a bug labels Feb 6, 2023
@scheglov scheglov added P1 A high priority bug; for example, a single project is unusable or has many test failures P2 A bug or feature request we're likely to work on and removed P1 A high priority bug; for example, a single project is unusable or has many test failures labels Feb 15, 2023
@mit-mit
Copy link
Member

mit-mit commented Feb 23, 2023

@srawlins @bwilkerson @kallentu what remains here?

It seems to work:

Screenshot 2023-02-23 at 15 16 19

@bwilkerson
Copy link
Member

Sorry for the confusion. We've been tracking this work on #50737 because we'd already started using the other issue before this one was created and just never took the time to tease the work apart. We probably should have done that.

To summarize, though, there's some work to do in code completion (CL is in progress) to not propose sealed classes in places where they shouldn't be proposed. There's also some work to do to make sure that our quick fixes and quick assists have been updated where necessary to work with sealed and other class modifiers. I'm hoping that the former can land before beta 2, but the other will be less noticeable if if slips to beta 3.

@srawlins
Copy link
Member

srawlins commented Mar 2, 2023

We can 100% close this issue as duplicate of #50737 if that is how we're functionally tackling this work. No downside to that from a tracking perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devexp-server Issues related to some aspect of the analysis server legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

6 participants