Skip to content

[Sealed class] Kythe implementation #51293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #51278
itsjustkevin opened this issue Feb 6, 2023 · 5 comments
Closed
Tracked by #51278

[Sealed class] Kythe implementation #51293

itsjustkevin opened this issue Feb 6, 2023 · 5 comments
Assignees
Labels
area-google3 Tracking issues for internal work. Note that this area is not triaged.

Comments

@itsjustkevin
Copy link
Contributor

No description provided.

@devoncarew devoncarew added the area-google3 Tracking issues for internal work. Note that this area is not triaged. label Feb 7, 2023
@leafpetersen
Copy link
Member

Anything to do here? @srawlins ?

@srawlins
Copy link
Member

srawlins commented May 8, 2023

There probably is. I believe @davidmorgan 's team has handled this in the past.

@davidmorgan
Copy link
Contributor

I think @yanok plans to do this one.

@yanok
Copy link
Contributor

yanok commented May 17, 2023

Sure, it's on my list.

@yanok yanok self-assigned this May 17, 2023
@yanok
Copy link
Contributor

yanok commented Jul 20, 2023

It turned out there was nothing to do for the "sealed class" feature specifically.

Kythe supports sum node kind, but as sealed classes in Dart can contain fields, it seems to be correct to keep using record node kind for them.
I don't see a way to express the fact that "these are the variants of this sum type" in Kythe. But that won't be very useful for Dart anyway, since in Dart we do variants via subclassing and subclasses are already supported in Kythe.

So I think we can just close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-google3 Tracking issues for internal work. Note that this area is not triaged.
Projects
None yet
Development

No branches or pull requests

6 participants