Skip to content

implement precedence in DartPatternImpl subclasses #51426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pq opened this issue Feb 15, 2023 · 2 comments
Closed

implement precedence in DartPatternImpl subclasses #51426

pq opened this issue Feb 15, 2023 · 2 comments
Assignees
@scheglov
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@pq
Copy link
Member

pq commented Feb 15, 2023

See TODO in DartPatternImpl:

  @override
  // TODO(brianwilkerson) Remove this and implement it in subclasses when we
  //  have constants for pattern-related precedence values.
  Precedence get precedence => throw UnimplementedError();

This is required to detect unnecessary parenthesis in the linter #59037.

/fyi @bwilkerson @scheglov
@pq pq added P1 A high priority bug; for example, a single project is unusable or has many test failures legacy-area-analyzer Use area-devexp instead. devexp-linter Issues with the analyzer's support for the linter package labels Feb 15, 2023
@scheglov scheglov self-assigned this Feb 15, 2023
@scheglov
Copy link
Contributor

https://dart-review.googlesource.com/c/sdk/+/283740

@pq
Copy link
Member Author

pq commented Feb 17, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pq @scheglov