Skip to content

Quick Assists for Class Modifiers #51496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #50737
pq opened this issue Feb 22, 2023 · 3 comments
Closed
Tracked by #50737

Quick Assists for Class Modifiers #51496

pq opened this issue Feb 22, 2023 · 3 comments
Assignees
Labels
devexp-assist Issues with analysis server assists devexp-server Issues related to some aspect of the analysis server legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on

Comments

@pq
Copy link
Member

pq commented Feb 22, 2023

No description provided.

@pq pq added legacy-area-analyzer Use area-devexp instead. devexp-assist Issues with analysis server assists P2 A bug or feature request we're likely to work on labels Feb 22, 2023
@pq pq changed the title Quick Assists Quick Assists for Class Modifiers Feb 22, 2023
@pq pq added the devexp-server Issues related to some aspect of the analysis server label Feb 22, 2023
@keertip
Copy link
Contributor

keertip commented Feb 24, 2023

Some assists to be looked at:

  • convert class to enum
  • convert class to mixin

@bwilkerson
Copy link
Member

Would either of these require either (a) validating that the class isn't being used outside the defining library in a way that would prohibit the change or (b) making changes outside the defining library in order to account for the change?

@keertip
Copy link
Contributor

keertip commented Mar 7, 2023

These are quick assists that exist today. Added tests to the assists to make sure they don't trigger in invalid cases and work in other cases.

@keertip keertip closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devexp-assist Issues with analysis server assists devexp-server Issues related to some aspect of the analysis server legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on
Projects
None yet
Development

No branches or pull requests

3 participants