Skip to content

[macros] suppress lints in macro-generated augmentations #54875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pq opened this issue Feb 9, 2024 · 4 comments
Closed

[macros] suppress lints in macro-generated augmentations #54875

pq opened this issue Feb 9, 2024 · 4 comments
Assignees
@pq
Labels
devexp-linter Issues with the analyzer's support for the linter package feature-macros Implementation of the macros feature legacy-area-analyzer Use area-devexp instead. P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@pq
Copy link
Member

pq commented Feb 9, 2024

We're currently producing lints in generated augmentation libraries. In the long run (and as discussed), we will likely want to make seeing them configurable but in the short-run we should consider just suppressing them.

image

(Sorry BTW if this is a duplicate issue -- I couldn't find one open already.)

Happy to take a look at this if no one is already.

/fyi @bwilkerson @scheglov @keertip
@pq pq added P1 A high priority bug; for example, a single project is unusable or has many test failures legacy-area-analyzer Use area-devexp instead. devexp-linter Issues with the analyzer's support for the linter package feature-macros Implementation of the macros feature labels Feb 9, 2024
@pq pq self-assigned this Feb 9, 2024
@pq
Copy link
Member Author

pq commented Feb 12, 2024

/fyi @jwren

@bwilkerson
Copy link
Member

I agree, until we've decided on a longer-term plan we should either stop running lints over generated files or we should filter them all out (emulating what ignore_for_file: type=lint would do).

@scheglov
Copy link
Contributor

We probably mean here not just any augmentations, but specifically macro generated augmentations.

@pq pq mentioned this issue Feb 14, 2024
Open
@pq
Copy link
Member Author

pq commented Feb 14, 2024

See also: dart-lang/language#3346

@pq pq changed the title [macros] suppress lints in augmentations [macros] suppress lints in macro-generated augmentations Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
devexp-linter Issues with the analyzer's support for the linter package feature-macros Implementation of the macros feature legacy-area-analyzer Use area-devexp instead. P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
Static Metaprogramming - design/prototype
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pq @scheglov @bwilkerson