Skip to content

[analyzer] Report a compile-time error when an expression of type void is used #54890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eernstg opened this issue Feb 12, 2024 · 6 comments
Closed
Labels
dart-model-analyzer-spec Issues with the analyzer's implementation of the language spec legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on

Comments

@eernstg
Copy link
Member

eernstg commented Feb 12, 2024

This is the analyzer specific issue for #54889, which has the details.

@bwilkerson
Copy link
Member

@scheglov

@pq pq added the P2 A bug or feature request we're likely to work on label Feb 13, 2024
@eernstg eernstg added the status-blocked Blocked from making progress by another (referenced) issue label Feb 14, 2024
@eernstg
Copy link
Member Author

eernstg commented Feb 14, 2024

@scheglov and @pq, this turns out to potentially need a breaking change process, so please do not proceed to work on the implementation at this time.

I've added a 'status-blocked' label to make this situation visible. I'll remove it again if and when the breaking change is approved. The description of the changes may be modified during this breaking change process.

I hope this bad ordering of events did not disrupt your work.

@scheglov
Copy link
Contributor

image

@lrhn
Copy link
Member

lrhn commented Feb 14, 2024

(I can't read Russian, but I get the point 😁)

@bwilkerson
Copy link
Member

Me either, so I used Google Lens to translate it. Not sure how well Lens did :-), but I also got the point.

@eernstg eernstg removed the status-blocked Blocked from making progress by another (referenced) issue label Feb 27, 2024
@eernstg
Copy link
Member Author

eernstg commented Feb 27, 2024

Closing: Various adjustments of the test (including corrections of mistakes introduced by the migration from a //# ... multi test to a modern // ^^^ test) have eliminated all test failures with the analyzer.

🎉

@eernstg eernstg closed this as completed Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart-model-analyzer-spec Issues with the analyzer's implementation of the language spec legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on
Projects
None yet
Development

No branches or pull requests

5 participants