Skip to content

[cfe] Report a compile-time error when an expression of type void is used #54891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eernstg opened this issue Feb 12, 2024 · 3 comments
Open
Labels
cfe-dysfunctionalities Issues for the CFE not behaving as intended front-end-missing-error legacy-area-front-end Legacy: Use area-dart-model instead.

Comments

@eernstg
Copy link
Member

eernstg commented Feb 12, 2024

This is the CFE specific issue for #54889, which has the details.

@eernstg
Copy link
Member Author

eernstg commented Feb 14, 2024

This turns out to potentially need a breaking change process, so please do not proceed to work on the implementation at this time.

I've added a 'status-blocked' label to make this situation visible. I'll remove it again if and when the breaking change is approved. The description of the changes may be modified during this breaking change process. I hope this bad ordering of events did not disrupt your work.

@eernstg eernstg added the status-blocked Blocked from making progress by another (referenced) issue label Feb 14, 2024
@eernstg
Copy link
Member Author

eernstg commented Feb 27, 2024

Various adjustments of the test (including corrections of mistakes introduced by the migration from a //# ... multi test to a modern // ^^^ test) have eliminated all test failures with the CFE except 3, and they are all concerned with expressions of the form e += 1 where e has static type void.

The issue is still on the agenda of the language team, but I expect that it will be considered as a non-breaking bug fix to start reporting an error in those cases. I'll unblock the issue and follow up when we have some input from the language team.

@johnniwinther johnniwinther added the cfe-dysfunctionalities Issues for the CFE not behaving as intended label Feb 27, 2024
@eernstg eernstg removed the status-blocked Blocked from making progress by another (referenced) issue label Feb 28, 2024
@eernstg
Copy link
Member Author

eernstg commented Feb 28, 2024

OK, the language team accepted that this is not a breaking change. Removing the 'status-blocked' label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cfe-dysfunctionalities Issues for the CFE not behaving as intended front-end-missing-error legacy-area-front-end Legacy: Use area-dart-model instead.
Projects
None yet
Development

No branches or pull requests

2 participants