Skip to content

extension type auto import #55443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cedvdb opened this issue Apr 12, 2024 · 5 comments
Closed

extension type auto import #55443

cedvdb opened this issue Apr 12, 2024 · 5 comments
Labels
devexp-quick-fix Issues with analysis server (quick) fixes devexp-server Issues related to some aspect of the analysis server legacy-area-analyzer Use area-devexp instead. P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug

Comments

@cedvdb
Copy link
Contributor

cedvdb commented Apr 12, 2024

Related #38894

extension type UserId(String _value) implements String {}

I'd expect the above to be discoverable and not have to manually type the import each time.

@lrhn
Copy link
Member

lrhn commented Apr 12, 2024

It should be as discoverable as a class. If it isn't, that is probably a mistake.

@lrhn lrhn added the legacy-area-analyzer Use area-devexp instead. label Apr 12, 2024
@scheglov scheglov added devexp-completion Issues with the analysis server's code completion feature devexp-server Issues related to some aspect of the analysis server P3 A lower priority bug or feature request labels Apr 12, 2024
@srawlins srawlins added the type-enhancement A request for a change that isn't a bug label Apr 26, 2024
@Tienisto
Copy link
Contributor

The extension is visible while writing (autocomplete) but there is no "Quick Fix" after the extension type has been already written.

@denniskaselow
Copy link

The quick fix is available on the constructor:
image

But not on the type:
image

@bwilkerson bwilkerson added devexp-quick-fix Issues with analysis server (quick) fixes and removed devexp-completion Issues with the analysis server's code completion feature labels Sep 24, 2024
@cedvdb
Copy link
Contributor Author

cedvdb commented Sep 30, 2024

This was closed but the PR above was not merged ?

@FMorschel
Copy link
Contributor

@cedvdb
Yes, it was a little weird the first time I saw this. The issue was closed on Gerrit. If you take a look at the PR there is a bot telling you about a new link:

https://dart-review.googlesource.com/c/sdk/+/386701

This is where the code got merged. They usually don't use PRs I was starting to help when I opened it. They use CLs directly at Gerrit. Since the code was already committed in Gerrit, the PR can't be merged, so it looks like it got closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devexp-quick-fix Issues with analysis server (quick) fixes devexp-server Issues related to some aspect of the analysis server legacy-area-analyzer Use area-devexp instead. P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants