Skip to content

[Wildcard Variables] VS Code Support #55726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #55673
kallentu opened this issue May 14, 2024 · 3 comments
Closed
Tracked by #55673

[Wildcard Variables] VS Code Support #55726

kallentu opened this issue May 14, 2024 · 3 comments
Assignees
Labels
area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas). feature-wildcard-variables Implementation of the wildcard variables feature

Comments

@kallentu
Copy link
Member

This issue tracks the wildcard variables work needed for VS Code.
If no work needs to be done, feel free to close it.

cc @jwren

@lrhn lrhn added the area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas). label May 16, 2024
@kallentu kallentu added the feature-wildcard-variables Implementation of the wildcard variables feature label May 17, 2024
@DanTup
Copy link
Collaborator

DanTup commented Jun 26, 2024

I don't think there's any work for either VS Code of the textmate grammar, unless we perhaps want to color _ differently to normal variables (for semantic tokens this would be done in the analysis servers highlights, but for the textmate grammar we don't currently colour variables at all because it's not a complete grammar).

cc @bwilkerson in case he can think of anything else I've overlooked.

@bwilkerson
Copy link
Member

No, I can't think of anything. The grammar hasn't changed, so most other tooling ought to not be impacted.

... unless we perhaps want to color _ differently to normal variables ...

I don't think we're currently coloring wildcard patterns differently, and I would expect that we'd want to color all wildcards the same way.

@DanTup
Copy link
Collaborator

DanTup commented Jun 26, 2024

Makes sense, closing this as nothing to do then. Thanks!

@DanTup DanTup closed this as completed Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas). feature-wildcard-variables Implementation of the wildcard variables feature
Projects
None yet
Development

No branches or pull requests

5 participants