Skip to content

[enhance] close_sinks rule false positive #58230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huang12zheng opened this issue Sep 17, 2020 · 0 comments
Open

[enhance] close_sinks rule false positive #58230

huang12zheng opened this issue Sep 17, 2020 · 0 comments
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. devexp-linter Issues with the analyzer's support for the linter package linter-false-positive P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@huang12zheng
Copy link

class PassportBloc extends FormBloc<String,String> with PasswordFormMixin{
  /// injectong to close <----
  PassportBloc(){
    addFieldBlocs(
      fieldBlocs: [password, confirmPassword]
    );
  }
  @override
  void onSubmitting() {
  }

}

mixin PasswordFormMixin on FormBloc<String,String>{

  final userName = TextFieldBloc(
    validators: [FieldBlocValidators.required]
  );
  /// would close in [PassportBloc].close by construction's injection <----
  //ignore: close_sinks
  final password = TextFieldBloc(
    validators: [FieldBlocValidators.required]
  );
  /// [PassportBloc]
  //ignore: close_sinks
  final confirmPassword = TextFieldBloc(
    validators: [FieldBlocValidators.required]
  );

It mightn‘t have something to do with #57882

@pq pq added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) linter-false-positive labels Dec 23, 2020
@srawlins srawlins added the P3 A lower priority bug or feature request label Sep 25, 2022
@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. labels Nov 18, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 18, 2024
@bwilkerson bwilkerson added area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. and removed legacy-area-analyzer Use area-devexp instead. labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. devexp-linter Issues with the analyzer's support for the linter package linter-false-positive P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

5 participants