Skip to content

extend constant_identifier_names to include record expressions #58843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #58831
pq opened this issue Aug 29, 2022 · 4 comments · Fixed by dart-archive/linter#3662
Closed
Tracked by #58831

extend constant_identifier_names to include record expressions #58843

pq opened this issue Aug 29, 2022 · 4 comments · Fixed by dart-archive/linter#3662
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. linter-new-language-feature linter-set-recommended P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@pq
Copy link
Member

pq commented Aug 29, 2022

No description provided.

@pq pq added linter-new-language-feature P1 A high priority bug; for example, a single project is unusable or has many test failures labels Aug 29, 2022
@bwilkerson
Copy link
Member

I'm not sure what you mean by "record declarations". An example would probably help.

@pq
Copy link
Member Author

pq commented Aug 29, 2022

Ah, maybe I mean record "expressions".

I was thinking something like:

const r = (x: 1); //OK
const R = (x: 1); //LINT

@pq pq changed the title extend constant_identifier_names to include record declarations extend constant_identifier_names to include record expressions Aug 29, 2022
@bwilkerson
Copy link
Member

The initializers are record literals. I would expect that the lint wouldn't depend on the kind of expression on the right-hand side, so there shouldn't be anything to do here.

@pq
Copy link
Member Author

pq commented Aug 29, 2022

Great! Well that'll be easy. 😄 I'll go ahead and just add a test.

Thanks!

@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. labels Nov 19, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. linter-new-language-feature linter-set-recommended P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants