Skip to content

unnecessary_nullable_for_final_variable_declarations should have tests with patterns #59084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srawlins opened this issue Mar 21, 2023 · 0 comments · Fixed by dart-archive/linter#4189
Closed

unnecessary_nullable_for_final_variable_declarations should have tests with patterns #59084

srawlins opened this issue Mar 21, 2023 · 0 comments · Fixed by dart-archive/linter#4189
Assignees
@pq
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. linter-false-negative linter-new-language-feature linter-set-recommended P2 A bug or feature request we're likely to work on
Milestone
Dart 3 beta 3

Comments

@srawlins
Copy link
Member

Child issue of #58837

I think there should be a test case like:

final (List<int>? a, List<int?> b, num? c) = ([], [], 1);

in which the lint rule would report that all three of the types are unnecessarily nullable.
@pq pq added this to the Dart 3 beta 3 milestone Mar 21, 2023
@pq pq self-assigned this Mar 21, 2023
@pq pq mentioned this issue Mar 22, 2023
Merged
@pq pq added the P2 A bug or feature request we're likely to work on label Mar 22, 2023
@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. labels Nov 19, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. linter-false-negative linter-new-language-feature linter-set-recommended P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
Dart 3 beta 3
3 participants
@pq @srawlins @devoncarew