Skip to content

Wrong highlight region for unnecessary_late #59292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bwilkerson opened this issue Sep 1, 2023 · 2 comments
Closed

Wrong highlight region for unnecessary_late #59292

bwilkerson opened this issue Sep 1, 2023 · 2 comments
Assignees
@pq
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. linter-set-recommended P2 A bug or feature request we're likely to work on

Comments

@bwilkerson
Copy link
Member

The lint unnecessary_late should highlight the keyword late, not the name of the field. Doing so will direct the user's attention to the right location, and will make it easier to write a fix (if there isn't already one).
@pq pq self-assigned this Sep 1, 2023
@pq pq added the P2 A bug or feature request we're likely to work on label Sep 1, 2023
@pq
Copy link
Member

pq commented Sep 1, 2023

I agree 💯.

FWIW, this is just another case that justifies the source migration -- the fix (in progress) has to be applied to the linter and server atomically. Now trivial! 🎉

copybara-service bot referenced this issue Sep 5, 2023
@pq
highlight the late token in unnecessary_late reports
ee2bc9d 
Fixes: https://github.com/dart-lang/linter/issues/4742

Change-Id: Ia13a325dc44a49f5aab3d564f3adc0c10e80c4f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/323940
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
@pq
Copy link
Member

pq commented Sep 5, 2023

Fixed w/ ee2bc9d.

@pq pq closed this as completed Sep 5, 2023
@pq pq mentioned this issue Sep 5, 2023
Closed
@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. labels Nov 20, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. linter-set-recommended P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pq @devoncarew @bwilkerson