-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[macros] support for non_constant_identifier_names
(variables and fields)
#59401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I agree. I think that's a concrete application of an even more general principle: we shouldn't lint where the author can't do anything to fix it.
I agree. They need to change the declaration being augmented first (and rename should rename any augmentations in the process).
As far as I can tell from the proposal it's fine if the names of positional parameter differ, so I'm guessing that we should lint that.
I think we should stop linting the names of overriding methods and the names of named parameters in overriding methods. |
With https://dart-review.googlesource.com/c/sdk/+/352978, all he cases except for variables and fields (which the parser doesn't support yet) should be covered. |
See: https://github.com/dart-lang/linter/issues/4883 Change-Id: Ia83e8a6e8e726bc3ef83ccbc5c0106f9698e4d4c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352978 Reviewed-by: Brian Wilkerson <[email protected]> Commit-Queue: Phil Quitslund <[email protected]>
non_constant_identifier_names
non_constant_identifier_names
(variables and fields)
non_constant_identifier_names
(variables and fields)non_constant_identifier_names
(variables and fields)
Fixes: https://github.com/dart-lang/linter/issues/4883 Change-Id: I817bd435e9ef5e940899c99944e7f60b06e11e5a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/361721 Reviewed-by: Brian Wilkerson <[email protected]> Commit-Queue: Phil Quitslund <[email protected]>
Fixed w/ 1c461dc |
No description provided.
The text was updated successfully, but these errors were encountered: