Skip to content

[augmentations] Ensure correct behavior in unreachable_from_main #59402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tracked by #59399
srawlins opened this issue Feb 16, 2024 · 0 comments
Open
Tracked by #59399

[augmentations] Ensure correct behavior in unreachable_from_main #59402

srawlins opened this issue Feb 16, 2024 · 0 comments
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. devexp-linter Issues with the analyzer's support for the linter package P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@srawlins
Copy link
Member

Child of #59399

unreachable_from_main walks all compilation units (parts) to determine an element's reachability (including public elements).

If a macro application augments a class with a constructor and/or a method, those need to be walked as well. For example, if a class has a public field which looks unused, but it used by a method found in an augmentation, that should be considered (unless we don't report unreachable instance fields/methods?).

@bwilkerson bwilkerson added the P2 A bug or feature request we're likely to work on label Mar 13, 2024
@srawlins srawlins added the type-enhancement A request for a change that isn't a bug label Mar 29, 2024
@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. labels Nov 20, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 20, 2024
@pq pq changed the title [macros] Ensure correct behavior in unreachable_from_main [augmentations] Ensure correct behavior in unreachable_from_main Feb 5, 2025
@bwilkerson bwilkerson added area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. and removed legacy-area-analyzer Use area-devexp instead. labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. devexp-linter Issues with the analyzer's support for the linter package P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants