Skip to content

[macros] don't report prefer_void_to_null on augmented declarations #59408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #59399
pq opened this issue Feb 20, 2024 · 2 comments
Closed
Tracked by #59399

[macros] don't report prefer_void_to_null on augmented declarations #59408

pq opened this issue Feb 20, 2024 · 2 comments
Assignees
@pq
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. linter-false-positive linter-new-language-feature linter-set-recommended P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug

Comments

@pq
Copy link
Member

pq commented Feb 20, 2024

No description provided.

@pq pq added P3 A lower priority bug or feature request linter-false-positive linter-new-language-feature labels Feb 20, 2024
@pq pq self-assigned this Feb 20, 2024
@pq pq mentioned this issue Feb 20, 2024
Open
@pq pq changed the title [macros] evaluate support for prefer_void_to_null [macros] don't report prefer_void_to_null on augmented methods/functions/fields Feb 20, 2024
copybara-service bot referenced this issue Feb 20, 2024
@pq
don't overreport prefer_void_to_null in augmentations
3f5a96b 
See: https://github.com/dart-lang/linter/issues/4890

Change-Id: Ie2f3364e781c5b62cbea252460b28ba48482a552
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353203
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
@pq pq changed the title [macros] don't report prefer_void_to_null on augmented methods/functions/fields [macros] don't report prefer_void_to_null on augmented declarations Feb 20, 2024
@pq
Copy link
Member Author

pq commented Feb 20, 2024

3f5a96b handles methods, getters, functions. We'll want to pickup with fields and variables when the parser supports them.

@pq pq changed the title [macros] don't report prefer_void_to_null on augmented declarations [macros] 🟡 don't report prefer_void_to_null on augmented declarations Feb 20, 2024
@srawlins srawlins added the type-enhancement A request for a change that isn't a bug label Mar 29, 2024
@pq pq changed the title [macros] 🟡 don't report prefer_void_to_null on augmented declarations [macros] don't report prefer_void_to_null on augmented declarations Apr 9, 2024
copybara-service bot referenced this issue Apr 9, 2024
@pq
don't lint prefer_void_to_null on augmented fields/top-level vars
18c0a39 
Fixes: https://github.com/dart-lang/linter/issues/4890

Change-Id: I9a44793e2e79ae946b5f010b9e588a6b8f29fc80
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362065
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
@pq
Copy link
Member Author

pq commented Apr 9, 2024

Fixed w/ 18c0a39

@pq pq closed this as completed Apr 9, 2024
@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. labels Nov 20, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. linter-false-positive linter-new-language-feature linter-set-recommended P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pq @srawlins @devoncarew