[augmentations] consider updating avoid_renaming_method_parameters to check augmented functions
#59409
Labels
area-devexp
For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages.
devexp-linter
Issues with the analyzer's support for the linter package
linter-new-language-feature
linter-set-recommended
P3
A lower priority bug or feature request
type-enhancement
A request for a change that isn't a bug
Comments
|
Yes, definitely I think it should. All the same justifications apply. |
pq
changed the title
avoid_renaming_method_parametersavoid_renaming_method_parameters to check augmented methods/functions
|
Completely generally, lints should apply to the end result of augmentation, since that's what the program really is. Something isn't missing if it's added by an augmentation. Some lints can also apply to intermediate steps, like this one. There is no reason to have a declaration with a different parameter name than the superclass, and then an augmentation on top which changes back to the superclass name. Other lints only care about the end result. Something like "always type public API" should only trigger if there are no types after augmentation. |
copybara-service bot
referenced
this issue
Apr 10, 2024
See: https://github.com/dart-lang/linter/issues/4891 Change-Id: I36dd1a82911ded0be716a37c08e1ae028bdd34ed Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362067 Commit-Queue: Phil Quitslund <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]>
|
Augmented methods are supported w/ 33f94fe. Will update the title to track future (possible) support for functions. |
pq
changed the title
avoid_renaming_method_parameters to check augmented methods/functionsavoid_renaming_method_parameters to check augmented functions
devoncarew
added
devexp-linter
pq
changed the title
avoid_renaming_method_parameters to check augmented functionsavoid_renaming_method_parameters to check augmented functions
bwilkerson
added
area-devexp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
avoid_renaming_method_parameters is specific to overridden methods.
Should it be extended to augmented methods/functions too?
EDIT: methods are now supported. Whether we want to extend this lint (or add another) for functions is an open question.
/cc @goderbauer @munificent @lrhn @natebosch @jakemac53
The text was updated successfully, but these errors were encountered: