Skip to content

[augmentations] support for use_enums #59416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tracked by #59399
pq opened this issue Feb 29, 2024 · 0 comments
Open
Tracked by #59399

[augmentations] support for use_enums #59416

pq opened this issue Feb 29, 2024 · 0 comments
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. devexp-linter Issues with the analyzer's support for the linter package linter-new-language-feature P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug

Comments

@pq
Copy link
Member

pq commented Feb 29, 2024 •
edited
Loading

e07160d handles over-reporting but as @bwilkerson points out there, we should consider using the element model to take into account members declared in augmentations.
@pq pq mentioned this issue Feb 29, 2024
Open
@pq pq self-assigned this Feb 29, 2024
@pq pq added linter-new-language-feature linter-false-positive P3 A lower priority bug or feature request labels Feb 29, 2024
@pq pq changed the title [macros] evaluate support for use_enums [macros] don't report use_enums on augmentation classes Feb 29, 2024
@pq pq changed the title [macros] don't report use_enums on augmentation classes [macros] support for use_enums Feb 29, 2024
@pq pq removed their assignment Feb 29, 2024
copybara-service bot referenced this issue Feb 29, 2024
@pq
don't report use_enums on augmentations
e07160d 
Addresses part of https://github.com/dart-lang/linter/issues/4900

Change-Id: I9fd292ed29d5bddd9cafe1c3c376941183fcab76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/355282
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
@srawlins srawlins added the type-enhancement A request for a change that isn't a bug label Mar 29, 2024
@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. labels Nov 20, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 20, 2024
@pq pq changed the title [macros] support for use_enums [augmentations] support for use_enums Feb 5, 2025
@bwilkerson bwilkerson added area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. and removed legacy-area-analyzer Use area-devexp instead. labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. devexp-linter Issues with the analyzer's support for the linter package linter-new-language-feature P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pq @srawlins @devoncarew @bwilkerson