Skip to content

[augmentations] support for avoid_equals_and_hash_code_on_mutable_classes #59440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tracked by #59399
pq opened this issue Apr 11, 2024 · 2 comments
Open
Tracked by #59399

[augmentations] support for avoid_equals_and_hash_code_on_mutable_classes #59440

pq opened this issue Apr 11, 2024 · 2 comments
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. devexp-linter Issues with the analyzer's support for the linter package linter-new-language-feature P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@pq
Copy link
Member

pq commented Apr 11, 2024 •
edited
Loading

TODO: detect @immutable annotations added via class augmentations.
@pq pq added P2 A bug or feature request we're likely to work on linter-new-language-feature labels Apr 11, 2024
@pq pq mentioned this issue Apr 11, 2024
Open
@srawlins srawlins added the type-enhancement A request for a change that isn't a bug label Apr 12, 2024
@pq pq self-assigned this Apr 16, 2024
copybara-service bot referenced this issue Apr 16, 2024
@pq
augmentation support for avoid_equals_and_hash_code_on_mutable_classes
9330195 
Fixes: https://github.com/dart-lang/linter/issues/4932

Change-Id: Ic9b20d81ae36536251568dbf25616b9ddc9f6693
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/363142
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
@pq
Copy link
Member Author

pq commented Apr 16, 2024

Fixed w/ 9330195

@pq pq closed this as completed Apr 16, 2024
@pq pq reopened this May 8, 2024
@pq
Copy link
Member Author

pq commented May 8, 2024

Currently blocked on analyzer implementation:

class AugmentedInstanceElementImpl {
  @override
  // TODO(scheglov): implement metadata
  List<ElementAnnotationImpl> get metadata => throw UnimplementedError();
}

copybara-service bot referenced this issue May 8, 2024
@pq
failing test for classes marked @immutable in augmentation
bae8334 
Implementation is currently blocked on `augmented.metadata` which throws an unimplemented exception in `AugmentedInstanceElementImpl`.

See: https://github.com/dart-lang/linter/issues/4932







Change-Id: I4dfd542ca9b7699deeadcd85098184f7ac82b4ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365923
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. labels Nov 20, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 20, 2024
@pq pq changed the title [macros] support for avoid_equals_and_hash_code_on_mutable_classes [augmentations] support for avoid_equals_and_hash_code_on_mutable_classes Feb 5, 2025
@bwilkerson bwilkerson added area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. and removed legacy-area-analyzer Use area-devexp instead. labels Feb 21, 2025
@pq pq removed their assignment Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. devexp-linter Issues with the analyzer's support for the linter package linter-new-language-feature P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pq @srawlins @devoncarew @bwilkerson