Skip to content

[Wildcard Variables] support for avoid_renaming_method_parameters #59483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #59471
pq opened this issue Jul 18, 2024 · 1 comment
Closed
Tracked by #59471

[Wildcard Variables] support for avoid_renaming_method_parameters #59483

pq opened this issue Jul 18, 2024 · 1 comment
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. linter-set-recommended P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@pq
Copy link
Member

pq commented Jul 18, 2024 •
edited
Loading

To be fixed w/ https://dart-review.googlesource.com/c/sdk/+/375900.
@pq pq mentioned this issue Nov 20, 2024
Closed
@pq pq changed the title [Wildcard Variables] evaluate support for avoid_renaming_method_parameters [Wildcard Variables] support for avoid_renaming_method_parameters Jul 18, 2024
@srawlins srawlins added type-enhancement A request for a change that isn't a bug P2 A bug or feature request we're likely to work on labels Jul 19, 2024
@pq
Copy link
Member Author

pq commented Aug 2, 2024

Fixed w https://dart-review.googlesource.com/c/sdk/+/375900.

@pq pq closed this as completed Aug 2, 2024
copybara-service bot referenced this issue Sep 5, 2024
@pq
[wildcards] allow overridden wildcards in `avoid_renaming_method_para…
4a7db83 
…meters`

Allow overriding methods to add variable names where they are declared as wildcards in their base implementation.

Follow-up from https://github.com/dart-lang/linter/issues/5025.

Change-Id: I5c9ad1dc5a946e5062cb51f8069ca3af1bd81a00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/383708
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. labels Nov 20, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. linter-set-recommended P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pq @srawlins @devoncarew