-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Window docs missing info #6098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yikes, LocalWindow has now disappeared. |
There should be MDN docs. The generated code still has @domName pointers.
|
Marked this as being blocked by #6213. |
A few of us were just talking about Window vs. LocalWindow, and we'd really like LocalWindow to be called Window (so it'll be easier to find). Here's a proposal for class names: LocalWindow -> Window |
Set owner to @vsmenon. |
This comment was originally written by [email protected] I've started documentation on this, but do we have any more ideas on naming LocalWindow -> Window? blois? cc @blois. |
We should make the LocalWindow->Window change soon. I opened bug http://code.google.com/p/dart/issues/detail?id=7516 to track. I sort of prefer WindowBase to BaseWindow (seems more common as a suffix, and keeps it located close to Window when browsing). Thoughts? |
This comment was originally written by [email protected] Marked this as being blocked by #7516. |
This comment was originally written by [email protected] Whoops. Edited wrong bug. cc @blois. |
This comment was originally written by [email protected] Removed Type-Defect label. |
Removed Area-DartDoc, Component-Docs, Type-Documentation labels. |
Now that 13291 is fixed, mem should be able to make these changes. Set owner to [email protected]. |
Juniper has been updating these docs, so I think this is stale? Added AssumedStale label. |
http://api.dartlang.org/docs/continuous/dart_html/LocalWindow.html has almost no doc comments, but it has recently become a top-10 HTML API page (according to analytics).
Particular questions that came up in IRC:
Exception: type '_DOMWindowCrossFrameImpl' is not a subtype of type 'LocalWindow' of 'ball'.
Stack Trace: #0 play.play
RESPONSE: That means that the returned type is not a LocalWindow.
Not sure what exactly it is, though.
The text was updated successfully, but these errors were encountered: