Skip to content

Completer.completeException should have a default stack trace #7037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nex3 opened this issue Nov 29, 2012 · 2 comments
Closed

Completer.completeException should have a default stack trace #7037

nex3 opened this issue Nov 29, 2012 · 2 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-not-planned Closed as we don't intend to take action on the reported issue library-async type-enhancement A request for a change that isn't a bug

Comments

@nex3
Copy link
Member

nex3 commented Nov 29, 2012

If Completer.completeException() is called without a stack trace, it should default to the stack trace of the call to completeException().
@nex3
Copy link
Member Author

nex3 commented Feb 26, 2013

Added Library-Async label.

@lrhn
Copy link
Member

lrhn commented Aug 23, 2013

That would make it impossible to complete without a stack-trace.
Getting a trace of the current stack is an expensive operation, and not making it optional seems dangerous.

We should have a way to easily get the current stacktrace (e.g., in a debug library), but we won't make it happen implicitly here.

Removed Type-Defect label.
Added Type-Enhancement, NotPlanned labels.

@nex3 nex3 added Type-Enhancement area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-async closed-not-planned Closed as we don't intend to take action on the reported issue labels Aug 23, 2013
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-not-planned Closed as we don't intend to take action on the reported issue library-async type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nex3 @kevmoo @lrhn