Skip to content

Remove the "ignoring exit code of DRT" hack #7563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mkustermann opened this issue Dec 21, 2012 · 1 comment
Closed

Remove the "ignoring exit code of DRT" hack #7563

mkustermann opened this issue Dec 21, 2012 · 1 comment
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@mkustermann
Copy link
Member

Currently we ignore the exit code of DumpRenderTree because DRT crashes sometimes although the tests passed. See http://dartbug.com/7536

Eventually we should remove this hack.
@ricowind
Copy link
Contributor

We actually do not ignore the exit code anymore, we print out that the exit code did not match with the test passing and exit with a failure, see issue #15139

Added Fixed label.

@mkustermann mkustermann added Type-Defect area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels Nov 25, 2013
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ricowind @mkustermann