Skip to content

update workflow permissions #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025
Merged

update workflow permissions #156

merged 1 commit into from
Jul 7, 2025

Conversation

devoncarew
Copy link
Member

  • update workflow permissions

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew
Copy link
Member Author

The failure on test_arch is:

Installing the windows-ia32 Dart SDK version 3.8.1 from the stable (release) channel.
https://storage.googleapis.com/dart-archive/channels/stable/release/3.8.1/sdk/dartsdk-windows-ia32-release.zip ...
Error: Error: Unexpected HTTP response: 404

with I assume is the issue that @mit-mit is looking to solve with #154 / #155.

@mit-mit
Copy link
Member

mit-mit commented Jul 3, 2025

What is the reason for updating permissions?

@devoncarew
Copy link
Member Author

What is the reason for updating permissions?

From your PR (#154) - we're seeing a permissions-too-broad warning:

Screenshot 2025-07-06 at 12 17 49 PM

@mit-mit mit-mit self-requested a review July 7, 2025 09:08
@mit-mit mit-mit merged commit fe21d53 into main Jul 7, 2025
27 of 28 checks passed
@mit-mit mit-mit deleted the update_workflow_permissions branch July 7, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants